-
Notifications
You must be signed in to change notification settings - Fork 190
Add Support for Testing with Output #580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
This can use C-u prefix, like it is implemented in https://github.com/ayrat555/cargo-mode . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! How about modifying rust-test to accept universal argument instead and allow it configure arbitrary argument instead ?
This would allow us to accept any arbitrary options to be passed instead of this specific usecase. You can look into rustic mode for inspiration: https://github.com/emacs-rustic/rustic?tab=readme-ov-file#test
Thank you, will definitely look into this suggestion when I get chance. |
|
Updated with the suggested change. Feel free to merge unless you want more changes, in which case let me know and I'll take a look. |
|
Hold on, I seem to have misread the suggestion, I'm going to convert to a draft while I figure this out. |
|
Sorry for the wait on this, should get to it soon :] |
|
I wanted to add an empty list of arguments that would be added to whenever you passed a I'm going to squash the commits into one then it should be ready to merge. |
This allows (optional) custom arguments to be passed the the rust-test function (press C-u before running the function).
|
|
|
@psibi Sorry for the ping, just wanted to ask if this is good to merge? Or if there's anything else you want added, let me know and I'll take a look. |
This PR solves the issue I raised in #579 by adding a new
rust-test-outputfunction.